[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#10162: [PATCH] 24.0.91; rcirc autojoin broken (freenode/oftc) when r
From: |
Noam Postavsky |
Subject: |
bug#10162: [PATCH] 24.0.91; rcirc autojoin broken (freenode/oftc) when rcirc-authenticate-before-join is set |
Date: |
Mon, 03 Jun 2019 18:16:01 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Steve Scott <steve@stevescott.ca> writes:
> Since the hostname returned by irc.freenode.net can be something other
> than irc.freenode.net, e.g. niven.freenode.net, the entries for
> rcirc-authinfo and rcirc-server-alist will not match.
Thanks, I was hitting this, and based on your explanation, I changed my
rcirc-authinfo entry to "[.]freenode[.]net\\'" instead of
"irc.freenode.net" and autojoin started working.
> + (if (and rcirc-auto-authenticate-flag
> + ;; We have to ensure that there's an authentication
> + ;; entry for that server. Otherwise,
> + ;; there's no point in calling authenticate.
> + (let (auth-required)
> + (dolist (s rcirc-authinfo auth-required)
> + (when (string-match (car s) rcirc-server)
> + (setq auth-required t)))))
> + (if rcirc-authenticate-before-join
But it looks like we're still calling authenticate, even in the
"otherwise" case, even though you say there's no point?