[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35506: 27.0.50; Emacs hangs while interrupting tramp processes
From: |
Michael Albinus |
Subject: |
bug#35506: 27.0.50; Emacs hangs while interrupting tramp processes |
Date: |
Sat, 04 May 2019 18:36:15 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
John Shahid <jvshahid@gmail.com> writes:
Hi John,
>> So your patch is correct, pls push.
>
> Thanks for reviewing the patch. Unfortunately, I don't have push access
> to the repository. Do you mind pushing the patch for me?
Done, pushed to master.
> 1. Asynchronously kill the process (the first patch)
> 2. Always return success, e.g. return proc.
>
> It doesn't make sense to use the default interrupt function for remote
> processes anyway, so always succeeding seems like the right thing to do
> here. This begs the question, why do we have to wait for the process
> output at all?
Well, the caller wants to know whether `interrupt-process' succeeded.
>> So we must investigate, why `interrupt-process' does not return in
>> your case.
>
> That is a good point. I didn't look deeply into why the `with-timeout'
> isn't timing out in my case. I will try to understand what is going on
> in the next few days.
IIRC, `tramp-accept-process-output' suppresses timers. So we might
change the code to (untested)
;; Wait, until the process has disappeared. If it doesn't,
;; fall back to the default implementation.
(and (tramp-accept-process-output proc 1)
;; Report success.
proc)))))
Does this work for you?
> Cheers,
>
> JS
Best regards, Michael.
- bug#35506: 27.0.50; Emacs hangs while interrupting tramp processes, Michael Albinus, 2019/05/03
- bug#35506: 27.0.50; Emacs hangs while interrupting tramp processes, John Shahid, 2019/05/04
- bug#35506: 27.0.50; Emacs hangs while interrupting tramp processes,
Michael Albinus <=
- bug#35506: 27.0.50; Emacs hangs while interrupting tramp processes, John Shahid, 2019/05/04
- bug#35506: 27.0.50; Emacs hangs while interrupting tramp processes, John Shahid, 2019/05/04
- bug#35506: 27.0.50; Emacs hangs while interrupting tramp processes, Michael Albinus, 2019/05/14
- bug#35506: 27.0.50; Emacs hangs while interrupting tramp processes, John Shahid, 2019/05/14
- bug#35506: 27.0.50; Emacs hangs while interrupting tramp processes, Michael Albinus, 2019/05/15