[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35468: [PATCH] Refactor draw_glyph_string on X and w32
From: |
Alan Third |
Subject: |
bug#35468: [PATCH] Refactor draw_glyph_string on X and w32 |
Date: |
Wed, 1 May 2019 22:08:47 +0100 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
On Wed, May 01, 2019 at 08:38:17PM +0300, Eli Zaretskii wrote:
> > Date: Tue, 30 Apr 2019 21:11:29 +0100
> > From: Alan Third <alan@idiocy.org>
> > Cc: Alex Gramiak <agrambot@gmail.com>, 35468@debbugs.gnu.org
> >
> > > > if (s->hl == DRAW_MOUSE_FACE)
> > > > {
> > > > face = FACE_FROM_ID_OR_NULL (s->f,
> > > > MOUSE_HL_INFO
> > > > (s->f)->mouse_face_face_id);
> > > > if (!face)
> > > > face = FACE_FROM_ID (s->f, MOUSE_FACE_ID);
> > > > }
> > > > else
> > > > face = s->face;
> > >
> > > I don't know why this is TRT, either. We could ask Alan to look into
> > > this, or we could simply remove that, as other terminals don't use
> > > box_line_width from the mouse face, they use s->face instead.
> >
> > A quick test doesn’t turn up any immediate issues with removing this,
> > but I’m unsure in what circumstances DRAW_MOUSE_FACE would be in use.
>
> E.g., when you hover the mouse pointer above the mouse-sensitive
> portions of the mode line.
It looks exactly the same to me with or without the code. Perhaps I’d
see something different if I was using some theme which defined mouse
face differently.
I really don’t see any reason why NS should behave differently from
the other terms here.
--
Alan Third
- bug#35468: [PATCH] Refactor draw_glyph_string on X and w32, Eli Zaretskii, 2019/05/01
- bug#35468: [PATCH] Refactor draw_glyph_string on X and w32,
Alan Third <=
- bug#35468: [PATCH] Refactor draw_glyph_string on X and w32, Eli Zaretskii, 2019/05/01
- bug#35468: [PATCH] Refactor draw_glyph_string on X and w32, Alex Gramiak, 2019/05/02
- bug#35468: [PATCH] Refactor draw_glyph_string on X and w32, Eli Zaretskii, 2019/05/04
- bug#35468: [PATCH] Refactor draw_glyph_string on X and w32, Alex Gramiak, 2019/05/04
- bug#35468: [PATCH] Refactor draw_glyph_string on X and w32, mituharu, 2019/05/04
- bug#35468: [PATCH] Refactor draw_glyph_string on X and w32, Eli Zaretskii, 2019/05/05