bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35418: [PATCH] Don't poll auto-revert files that use notification


From: Mattias Engdegård
Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification
Date: Thu, 25 Apr 2019 20:07:38 +0200

25 apr. 2019 kl. 12.04 skrev Eli Zaretskii <eliz@gnu.org>:
> 
>>   "^" (regexp-opt '("/afs/" "/media/" "/mnt" "/net/" "/tmp_mnt/"))
>> 
>> If that regexp is acceptable as rough heuristics on Unix, surely something 
>> like the regexp proposed, matching \\SOMETHING\, shouldn't be out of the 
>> question on Windows? Full precision cannot be attained, as you point out, 
>> but perhaps we can make life easier for the user.
> 
> on Windows, SOMETHING is just the name of the machine which exports
> the drive, it can be anything.

Right, it's just a path to a file or directory on a mounted remote file system.

>> Are you arguing that the default value of 
>> auto-revert-notify-exclude-dir-regexp should not be extended in the proposed 
>> way, or that the variable is fundamentally incompatible with the patch?
> 
> I'm questioning the usefulness of extending the default value, yes.
> But I don't have strong views on that.

Nor do I. It would avoid breaking auto-revert on some non-auto-revert-capable 
remote file systems on Windows, at the cost of increasing the auto-revert delay 
on some auto-revert-capable remote file systems.
The patch does not hinge on a change to the default value of that variable.

I forgot to mention that this patch should and will be accompanied by 
appropriate NEWS and documentation updates, to be written.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]