bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32793: 27.0.50; json-parse-string doesn't have the equivalent of jso


From: Dmitry Gutov
Subject: bug#32793: 27.0.50; json-parse-string doesn't have the equivalent of json.el's json-array-type
Date: Fri, 12 Apr 2019 18:45:46 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 12.04.2019 18:26, Eli Zaretskii wrote:

This argument is meaningless for serializing, I think.  But OK.

I wouldn't be so sure. For instance, one could attempt to resolve the alist-list conflict using a combination of :object-type and :array-type parameters. This isn't going to work, at least not yet. It's better to fail earlier.

You just didn't try an array big enough for this to matter.

My array was big enough for the switch from json.el to json.c to make a real difference.

Anyway, it depends on how "big" the elements inside the array are as well. In my case they're fairly complex too.

I don't mind, although in that case the loop just assigns value to a
vector that was already consed.

It also calls

  json_to_lisp (json_array_get (json, i), conf)

in that loop.

json-parse-buffer and NEWS don't need updating, I think.

They don't?  Why not?

There was no json.c in Emacs 26. NEWS describes the changes from the previous release, and the current entry only lists the public functions.

json-parse-buffer doesn't enumerate the keyword arguments either.

+The keyword argument `:array-type' specifies which Lisp type is used
+to represent arrays; it can be `array' or `list'.

Please say here that 'array' is the default.

OK. I've had to update the preceding paragraph as well.

Good to install?

Attachment: json-array-type.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]