[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35062: [PATCH v3 1/3] Remove redundant comparison
From: |
Konstantin Kharlamov |
Subject: |
bug#35062: [PATCH v3 1/3] Remove redundant comparison |
Date: |
Sun, 7 Apr 2019 05:13:29 +0300 |
* src/xterm.c (x_set_frame_alpha): due to preceding checks it is bound
to be 0 ≤ alpha ≤ 1. (Bug#35062)
---
v3: mention functions changed in commit messages, mention the bug
number, and don't mention that it fixes a warning since intention of
changes is clear either way.
src/xterm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/xterm.c b/src/xterm.c
index f90d6713b02..e8f1e576a38 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -931,7 +931,7 @@ x_set_frame_alpha (struct frame *f)
return;
else if (alpha > 1.0)
alpha = 1.0;
- else if (0.0 <= alpha && alpha < alpha_min && alpha_min <= 1.0)
+ else if (alpha < alpha_min && alpha_min <= 1.0)
alpha = alpha_min;
opac = alpha * OPAQUE;
--
2.21.0
- bug#35062: [PATCH v3 1/3] Remove redundant comparison,
Konstantin Kharlamov <=
- bug#35062: [PATCH v3 3/3] don't compare unsigned to less-than-zero, Konstantin Kharlamov, 2019/04/06
- bug#35062: [PATCH v3 2/3] constify a bit of xterm.c, Konstantin Kharlamov, 2019/04/06
- bug#35062: [PATCH v3 2/3] constify a bit of xterm.c, Eli Zaretskii, 2019/04/13
- bug#35062: [PATCH v3 2/3] constify a bit of xterm.c, Paul Eggert, 2019/04/19
- bug#35062: [PATCH v3 2/3] constify a bit of xterm.c, Konstantin Kharlamov, 2019/04/19
- bug#35062: [PATCH v3 2/3] constify a bit of xterm.c, Konstantin Kharlamov, 2019/04/19
- bug#35062: [PATCH v3 2/3] constify a bit of xterm.c, Eli Zaretskii, 2019/04/20