[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions
From: |
Eli Zaretskii |
Subject: |
bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions |
Date: |
Fri, 05 Apr 2019 10:05:14 +0300 |
> From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> Date: Tue, 2 Apr 2019 03:23:27 +0300
>
> * src/gtkutil.c:
> remove "always false" comparison
> remove multiplication by zero, it's a noop anyway
> remove min_cols and min_rows as it's now unused
>
> Fixes LGTM warnings:
> * Comparison is always false because min_cols <= 0.
> * Comparison is always false because min_rows <= 0.
> ---
> v2: remove the min_rows/min_cols whatsoever
Thanks, pushed. Please in the future write the commit log messages in
the ChangeLog-like style, see CONTRIBUTE for the details. I did that
this time, you can look at what I pushed to see an example of that
style in action.
- bug#35062: [PATCH 3/4] min_cols/rows is always 0, don't check for it, Noam Postavsky, 2019/04/01
- bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions, Konstantin Kharlamov, 2019/04/01
- bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions,
Eli Zaretskii <=
- bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions, Konstantin Kharlamov, 2019/04/05
- bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions, Eli Zaretskii, 2019/04/06
- bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions, Konstantin Kharlamov, 2019/04/06
- bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions, Eli Zaretskii, 2019/04/06
- bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions, Michael Albinus, 2019/04/06