bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#33225: [debbugs.el] Don't send control message immediately


From: Michael Albinus
Subject: bug#33225: [debbugs.el] Don't send control message immediately
Date: Mon, 01 Apr 2019 16:52:17 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Noam Postavsky <npostavs@gmail.com> writes:

Hi Noam,

>> I'd prefer if you would commit your changes so far, that we have a
>> common base, and further patches you'll show are shorter (to review).
>
> Yes, I would open a new bug thread for the feature I mention above,
> after this is one is closed and pushed.

OK.

>>> +@item found
>>> +@itemx notfound
>>> +@itemx fixed
>>> +"found|notfound|fixed 12345 25.1"
>>
>> Please add notfixed.
>
> Done.  Hmm, I just noticed that we have "@itemx fixed" in two places.
> So there is a conflict between "fixed" as a tag, and "fixed" as its own
> command.  I think the command should precedence (that was already the
> case in the code for previous patches, now I've updated the doc as
> well).

OK.

> One last thing I noticed when byte-compiling from emacs -Q, is that I
> needed to add a couple of autoloads for the message functions.  And then
> I realized that the message-narrow-to-head call should actually be
> message-narrow-to-headers, since the latter looks for
> mail-header-separator, while the former just looks for a blank line (in
> practice, it doesn't make much difference unless the message body
> happens to have text that looks like a mail header).

That was also on my todo list. I'm glad if you fix it (but, as finical
German, I prefer to insert them in alphabetical order).

There's nothing left I could nitpick, so pls commit :-)

Thanks, and best regards, Michael.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]