[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35062: [PATCH 3/4] min_cols/rows is always 0, don't check for it
From: |
Konstantin Kharlamov |
Subject: |
bug#35062: [PATCH 3/4] min_cols/rows is always 0, don't check for it |
Date: |
Mon, 1 Apr 2019 01:37:41 +0300 |
* src/gtkutil.c: remove unnecessary comparison
Fixes LGTM warnings:
* Comparison is always false because min_cols <= 0.
* Comparison is always false because min_rows <= 0.
---
src/gtkutil.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/gtkutil.c b/src/gtkutil.c
index 4bd73b1a6d1..64bc248d650 100644
--- a/src/gtkutil.c
+++ b/src/gtkutil.c
@@ -1401,7 +1401,7 @@ x_wm_set_size_hint (struct frame *f, long int flags, bool
user_position)
GdkGeometry size_hints;
gint hint_flags = 0;
int base_width, base_height;
- int min_rows = 0, min_cols = 0;
+ const int min_rows = 0, min_cols = 0;
int win_gravity = f->win_gravity;
Lisp_Object fs_state, frame;
int scale = xg_get_scale (f);
@@ -1450,9 +1450,6 @@ x_wm_set_size_hint (struct frame *f, long int flags, bool
user_position)
base_height = FRAME_TEXT_LINES_TO_PIXEL_HEIGHT (f, 1)
+ FRAME_MENUBAR_HEIGHT (f) + FRAME_TOOLBAR_HEIGHT (f);
- if (min_cols > 0) --min_cols; /* We used one col in base_width = ... 1); */
- if (min_rows > 0) --min_rows; /* We used one row in base_height = ... 1); */
-
size_hints.base_width = base_width;
size_hints.base_height = base_height;
size_hints.min_width = base_width + min_cols * FRAME_COLUMN_WIDTH (f);
--
2.21.0