bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25904: Patches


From: Jackson Ray Hamilton
Subject: bug#25904: Patches
Date: Sun, 10 Feb 2019 14:03:44 -0800 (PST)

Hello Dmitry and Felipe,

I’ve taken a stab at formatting Felipe’s fix for arrow function indentation according to the coding standards.  Compared to his patch, I made some trivial name/doc changes, and changed

(progn (forward-char) (js--looking-at-broken-arrow-function-p))

to

(save-excursion (forward-char) (js--looking-at-broken-arrow-function-p))

since we probably want to undo the forward-char in case the form returns nil.

In order to get all the JS indentation tests to pass with make, I also had to make a variable safe file-locally.

Both changes are attached.  They could be applied to the emacs-26 branch.  (Or master, but emacs-26 would be preferable so we can deliver it sooner.  I tested on both branches.)

Jackson

Attachment: 0001-Indent-arrows-expression-bodies-like-function-bodies.patch
Description: Text Data

Attachment: 0001-js-indent-align-list-continuation-Make-variable-safe.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]