bug#34051: "X protocol error: BadMatch" on current master

[Yuri D'Elia]

On Wed, Jan 16 2019, Yuri D'Elia wrote:
> On Mon, Jan 14 2019, Eli Zaretskii wrote:
>>> From: Yuri D'Elia <wavexx@thregr.org>
>>> Date: Mon, 14 Jan 2019 16:08:27 +0100
>>>
>>> Testing the master today I had some issues with emacs quitting with the
>>> following error:
>>>
>>> X protocol error: BadMatch (invalid parameter attributes) on protocol 
>>> request 139
>>>
>>> This happens during a minor mode setup, so I'm unsure exactly what is
>>> going on (didn't have time to dig deeper).
>>>
>>> However, last good commit is c342b26371480316024e1e5d63cd8b3f035dda69,
>>
>> Seems like bug#34051.
>>
>> If you run this under GDB with x-synchronize set to t, then post the
>> full backtrace from the crash, it would be very helpful.  (If you do,
>> please post that to 34051@debbugs.gnu.org.)
>
> So I rebuilt emacs @ a1b7a3f2a3957a399d6c3c7bcffa07ac67da82fc (first bad
> version). Running under gdb, (x-synchronize t), and then trigger the
> issue I get to the following point:
>
> #12 0x0000000000529716 in x_error_handler (display=0x2b83430, 
> event=0x7fffffff5840) at xterm.c:9930
> #13 0x00007ffff680511a in _XError () from 
> /usr/lib/x86_64-linux-gnu/libX11.so.6
> #14 0x00007ffff6802077 in ?? () from /usr/lib/x86_64-linux-gnu/libX11.so.6
> #15 0x00007ffff680211d in ?? () from /usr/lib/x86_64-linux-gnu/libX11.so.6
> #16 0x00007ffff6803050 in _XReply () from 
> /usr/lib/x86_64-linux-gnu/libX11.so.6
> #17 0x00007ffff67fe99d in XSync () from /usr/lib/x86_64-linux-gnu/libX11.so.6
> #18 0x00007ffff67fea3b in ?? () from /usr/lib/x86_64-linux-gnu/libX11.so.6
> #19 0x00007ffff6374b45 in XRenderCreatePicture () from 
> /usr/lib/x86_64-linux-gnu/libXrender.so.1
> #20 0x00000000006a6e4c in x_create_x_image_and_pixmap (f=0x1333c30 
> <bss_sbrk_buffer+8490736>, width=15, height=33, depth=1, ximg=0x7fffffff5c10, 
> pixmap=0x2e79eb8,
>     picture=0x2e79ed8) at image.c:2192
> #21 0x00000000006a6fea in image_create_x_image_and_pixmap (f=0x1333c30 
> <bss_sbrk_buffer+8490736>, img=0x2e79ea0, width=15, height=33, depth=1, 
> ximg=0x7fffffff5c10,
>     mask_p=true) at image.c:2370
> #22 0x00000000006ab32f in x_build_heuristic_mask (f=0x1333c30 
> <bss_sbrk_buffer+8490736>, img=0x2e79ea0, how=XIL(0xc7e0)) at image.c:5285
> #23 0x00000000006a5b74 in postprocess_image (f=0x1333c30 
> <bss_sbrk_buffer+8490736>, img=0x2e79ea0) at image.c:1728
> #24 0x00000000006a67ec in lookup_image (f=0x1333c30 
> <bss_sbrk_buffer+8490736>, spec=XIL(0x4133413)) at image.c:2002
> #25 0x000000000044424a in handle_single_display_spec (it=0x7fffffff75f0, 
> spec=XIL(0x4133413), object=XIL(0x41af004), overlay=XIL(0), 
> position=0x7fffffff7740, bufpos=84,
>     display_replaced=0, frame_window_p=true, enable_eval_p=true) at 
> xdisp.c:5359
> #26 0x0000000000442760 in handle_display_spec (it=0x7fffffff75f0, 
> spec=XIL(0x4132f33), object=XIL(0x41af004), overlay=XIL(0), 
> position=0x7fffffff7740, bufpos=84,
>     frame_window_p=true) at xdisp.c:4821
> #27 0x00000000004424ef in handle_display_prop (it=0x7fffffff75f0) at 
> xdisp.c:4764
> #28 0x000000000043f2ec in handle_stop (it=0x7fffffff75f0) at xdisp.c:3470
> #29 0x000000000044b7b0 in next_element_from_string (it=0x7fffffff75f0) at 
> xdisp.c:8072
> #30 0x0000000000448c98 in get_next_display_element (it=0x7fffffff75f0) at 
> xdisp.c:7051
> #31 0x0000000000471d52 in display_line (it=0x7fffffff75f0, cursor_vpos=1) at 
> xdisp.c:21605
> #32 0x0000000000467269 in try_window (window=XIL(0x1334c35), pos=..., 
> flags=1) at xdisp.c:17808
> #33 0x0000000000464d8d in redisplay_window (window=XIL(0x1334c35), 
> just_this_one_p=false) at xdisp.c:17255
> #34 0x000000000045e170 in redisplay_window_0 (window=XIL(0x1334c35)) at 
> xdisp.c:14983
> #35 0x00000000005fb710 in internal_condition_case_1 (bfun=0x45e12e 
> #<redisplay_window_0>, arg=XIL(0x1334c35), handlers=XIL(0xb84fd3),
> <cut>
>
> Let me know if that's enough or if I should also get those darn
> debugging symbols for X11...

Here's with debugging symbols too:

#0  futex_wait_cancelable (private=0, expected=0, futex_word=0x2b84798) at 
../sysdeps/unix/sysv/linux/futex-internal.h:88
#1  __pthread_cond_wait_common (abstime=0x0, mutex=0x2b8a8c0, cond=0x2b84770) 
at pthread_cond_wait.c:502
#2  __pthread_cond_wait (cond=0x2b84770, mutex=0x2b8a8c0) at 
pthread_cond_wait.c:655
#3  0x00007ffff6802ff2 in _XReply (dpy=dpy@entry=0x2b83430, 
rep=rep@entry=0x7fffffff52d0, extra=extra@entry=0, discard=discard@entry=1) at 
../../src/xcb_io.c:603
#4  0x00007ffff67fe99d in XSync (dpy=0x2b83430, discard=discard@entry=0) at 
../../src/Sync.c:44
#5  0x00007ffff67fea3b in _XSyncFunction (dpy=<optimized out>) at 
../../src/Synchro.c:35
#6  0x00007ffff6582dc8 in XftDrawDestroy () from 
/usr/lib/x86_64-linux-gnu/libXft.so.2
#7  0x00000000006972ec in xftfont_end_for_frame (f=0x1333c30 
<bss_sbrk_buffer+8490736>) at xftfont.c:688
#8  0x000000000061b40c in font_update_drivers (f=0x1333c30 
<bss_sbrk_buffer+8490736>, new_drivers=XIL(0)) at font.c:3543
#9  0x0000000000429dad in delete_frame (frame=XIL(0x1333c35), 
force=XIL(0x9f30)) at frame.c:2005
#10 0x0000000000529594 in x_connection_closed (dpy=0x2b83430,
    error_message=0x7fffffff55a0 "X protocol error: BadMatch (invalid parameter 
attributes) on protocol request 139", ioerror=false) at xterm.c:9851
#11 0x00000000005297bc in x_error_quitter (display=0x2b83430, 
event=0x7fffffff5840) at xterm.c:9960
#12 0x0000000000529716 in x_error_handler (display=0x2b83430, 
event=0x7fffffff5840) at xterm.c:9930
#13 0x00007ffff680511a in _XError (dpy=dpy@entry=0x2b83430, 
rep=rep@entry=0x3fb0680) at ../../src/XlibInt.c:1444
#14 0x00007ffff6802077 in handle_error (dpy=0x2b83430, err=0x3fb0680, 
in_XReply=<optimized out>) at ../../src/xcb_io.c:199
#15 0x00007ffff680211d in handle_response (dpy=dpy@entry=0x2b83430, 
response=0x3fb0680, in_XReply=in_XReply@entry=1) at ../../src/xcb_io.c:324
#16 0x00007ffff6803050 in _XReply (dpy=dpy@entry=0x2b83430, 
rep=rep@entry=0x7fffffff59f0, extra=extra@entry=0, discard=discard@entry=1) at 
../../src/xcb_io.c:634
#17 0x00007ffff67fe99d in XSync (dpy=0x2b83430, discard=discard@entry=0) at 
../../src/Sync.c:44
#18 0x00007ffff67fea3b in _XSyncFunction (dpy=<optimized out>) at 
../../src/Synchro.c:35
#19 0x00007ffff6374b45 in XRenderCreatePicture (dpy=0x2b83430, 
drawable=25166514, format=0x2b9df50, valuemask=0, attributes=0x7fffffff5ad0) at 
../../src/Picture.c:99
#20 0x00000000006a6e4c in x_create_x_image_and_pixmap (f=0x1333c30 
<bss_sbrk_buffer+8490736>, width=15, height=33, depth=1, ximg=0x7fffffff5c10, 
pixmap=0x2e44e28,
    picture=0x2e44e48) at image.c:2192
#21 0x00000000006a6fea in image_create_x_image_and_pixmap (f=0x1333c30 
<bss_sbrk_buffer+8490736>, img=0x2e44e10, width=15, height=33, depth=1, 
ximg=0x7fffffff5c10,
    mask_p=true) at image.c:2370
#22 0x00000000006ab32f in x_build_heuristic_mask (f=0x1333c30 
<bss_sbrk_buffer+8490736>, img=0x2e44e10, how=XIL(0xc7e0)) at image.c:5285
#23 0x00000000006a5b74 in postprocess_image (f=0x1333c30 
<bss_sbrk_buffer+8490736>, img=0x2e44e10) at image.c:1728
#24 0x00000000006a67ec in lookup_image (f=0x1333c30 <bss_sbrk_buffer+8490736>, 
spec=XIL(0x40b5773)) at image.c:2002
#25 0x000000000044424a in handle_single_display_spec (it=0x7fffffff75f0, 
spec=XIL(0x40b5773), object=XIL(0x417b324), overlay=XIL(0), 
position=0x7fffffff7740, bufpos=84,
    display_replaced=0, frame_window_p=true, enable_eval_p=true) at xdisp.c:5359
#26 0x0000000000442760 in handle_display_spec (it=0x7fffffff75f0, 
spec=XIL(0x40b5523), object=XIL(0x417b324), overlay=XIL(0), 
position=0x7fffffff7740, bufpos=84,
    frame_window_p=true) at xdisp.c:4821
#27 0x00000000004424ef in handle_display_prop (it=0x7fffffff75f0) at 
xdisp.c:4764
#28 0x000000000043f2ec in handle_stop (it=0x7fffffff75f0) at xdisp.c:3470
#29 0x000000000044b7b0 in next_element_from_string (it=0x7fffffff75f0) at 
xdisp.c:8072
#30 0x0000000000448c98 in get_next_display_element (it=0x7fffffff75f0) at 
xdisp.c:7051
#31 0x0000000000471d52 in display_line (it=0x7fffffff75f0, cursor_vpos=1) at 
xdisp.c:21605
#32 0x0000000000467269 in try_window (window=XIL(0x1334c35), pos=..., flags=1) 
at xdisp.c:17808
#33 0x0000000000464d8d in redisplay_window (window=XIL(0x1334c35), 
just_this_one_p=false) at xdisp.c:17255
#34 0x000000000045e170 in redisplay_window_0 (window=XIL(0x1334c35)) at 
xdisp.c:14983
#35 0x00000000005fb710 in internal_condition_case_1 (bfun=0x45e12e 
#<redisplay_window_0>, arg=XIL(0x1334c35), handlers=XIL(0xb84fd3),
<cut>