bug#32932: 27.0.50; render bugs on macOS Mojave

[Boris Buliga]

Yes, I've also noticed blanks with ivy.

But for sure this patch is a HUGE improvement. I had to work a little bit on a

machine where I didn't install this patch and I have encountered a lot of random

blanks.

--------------------------------------------------------------------------------

Aaron,

I will hopefully be able to test with the following line commented out.

w->phys_cursor_on_p = on_p;

On Thu, 1 Nov 2018 at 07:11, Aaron Jensen <aaronjensen@gmail.com> wrote:

On October 31, 2018 at 9:58:59 PM, Aaron Jensen
(aaronjensen@gmail.com(mailto:aaronjensen@gmail.com)) wrote:

> > On October 31, 2018 at 10:13:01 AM, Alan Third (alan@idiocy.org(mailto:alan@idiocy.org)) wrote:
> > > Something is blanking the line. There are only so many places where
> > > that happens so in theory it should be relatively straight‐forward to
> > > find the place in question. Perhaps start by commenting out the
> > > NSRectFill commands in ns_clear_frame and ns_clear_frame_area.
> >
> > I commented out every single NSRectFill and it still did it. It’s fast, but gif attached.
> >
> > I tried commenting out the setNeedsDisplay but that breaks rendering entirely.


Okay, the blank does not occur if I comment out this line:

  w->phys_cursor_on_p = on_p;

Hopefully that’s a helpful clue :)

The other place this blank happens is when opening a buffer from ivy.
The mini buffer blanks. It seems that has something to do w/ clearing
cursors from the non-active windows, perhaps it’s being a little
overzealous in its clearing and it doesn’t get a chance to paint
before the cpu starts churning.

Aaron

--

Cheers,

Boris