[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31772: 26.1; (thing-at-point 'list) regression
From: |
Leo Liu |
Subject: |
bug#31772: 26.1; (thing-at-point 'list) regression |
Date: |
Fri, 07 Sep 2018 12:42:55 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (macOS 10.12.6) |
On 2018-09-06 21:01 +0200, Andreas Röhler wrote:
> Hi Leo,
>
> lets consider the following proposed change of tests:
>
> - ("(foo\n(a ;(b c d)\ne) bar)" . (a e))
> + ("(foo\n(a ;(b c d)\ne) bar)" . (foo (a e) bar))
>
> As the ert-test mentioned calls (re-search-backward "\\((a\\|^a\\)")
>
> point will be behind foo at "(a". I.e. "foo" belongs to outer list,
> not to list-at-point. The desired result shown by this change looks
> wrong, "(foo" should not be part of.
>
> Maybe I'm missing something.
> May you provide a standalone example where current behavior breaks
> your code?
I carefully considered this case when preparing the patch.
In the last 10 years (thing-at-point 'list) always returns the enclosing
list so I opted to keep this for now. It is confusing and I don't like
it personally.
It can be tweaked to look at "list" at point first if that's what
everybody wants.
Cheers,
Leo