[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30724: eshell: escaped tilde is not treated as such
From: |
Jonathan Kyle Mitchell |
Subject: |
bug#30724: eshell: escaped tilde is not treated as such |
Date: |
Tue, 17 Jul 2018 22:54:27 -0500 |
On Mon, 2018-07-16 at 20:14 -0400, Noam Postavsky wrote:
> The "Add eshell-escape-special-filenames to symbol plist" should be
> coalesced, as in:
Done in the new attached patch.
> I'm not sure 'escaped' or 'eshell-escape-special-filenames' are
> really
> the right names here, as they're not actually indicating any
> escaping.
> Maybe the property should be something like 'eshell-filename-
> arguments'?
I changed the property name to eshell-filename-arguments.
> Comments should be capitalized and end with a period (I know the
> original didn't, but since we're updating the code, now is a good
> time
> to fix it).
Fixed both the original and new comment.
> It looks like this kind of escaping isn't actually needed for "*"
> which
> your previous patch mentioned. Perhaps just check for "~"
> explicitly,
> rather than any single character filenames. Or are there other
> examples
> besides "~" which need "./" to prevent interpretation?
I can't think of any other cases that would need to be check either, so
I changed to to just string-match "~" only.
--
Jonathan Kyle Mitchell
0001-Check-for-special-filenames-in-eshell-Bug-30724.patch
Description: Text Data