[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31946: 27.0.50; The NSM should warn about more TLS problems
From: |
Lars Ingebrigtsen |
Subject: |
bug#31946: 27.0.50; The NSM should warn about more TLS problems |
Date: |
Sun, 08 Jul 2018 20:36:58 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
And this it the patch. It'd have to be cleaned up and autoconfiged, of
course, if this turns out to be the way to go. (And who's
responsibility is it to clean up the data in &issuer anyway? I can't
use gnutls_free, because the datum itself shouldn't be freed...)
diff --git a/src/gnutls.c b/src/gnutls.c
index dfbbecfc87..69b64ae96d 100644
--- a/src/gnutls.c
+++ b/src/gnutls.c
@@ -1031,6 +1031,16 @@ gnutls_certificate_details (gnutls_x509_crt_t cert)
}
/* Issuer. */
+#if 1
+ {
+ gnutls_datum_t issuer;
+ err = gnutls_x509_crt_get_issuer_dn3 (cert, &issuer, 0);
+ if (err >= GNUTLS_E_SUCCESS)
+ res = nconc2 (res, list2 (intern (":issuer"),
+ make_string ((char *) issuer.data,
+ issuer.size)));
+ }
+#else
buf_size = 0;
err = gnutls_x509_crt_get_issuer_dn (cert, NULL, &buf_size);
check_memory_full (err);
@@ -1044,6 +1054,7 @@ gnutls_certificate_details (gnutls_x509_crt_t cert)
make_string (dn, buf_size)));
xfree (dn);
}
+#endif
/* Validity. */
{
@@ -1062,6 +1073,16 @@ gnutls_certificate_details (gnutls_x509_crt_t cert)
}
/* Subject. */
+#if 1
+ {
+ gnutls_datum_t subject;
+ err = gnutls_x509_crt_get_dn3 (cert, &subject, 0);
+ if (err >= GNUTLS_E_SUCCESS)
+ res = nconc2 (res, list2 (intern (":subject"),
+ make_string ((char *) subject.data,
+ subject.size)));
+ }
+#else
buf_size = 0;
err = gnutls_x509_crt_get_dn (cert, NULL, &buf_size);
check_memory_full (err);
@@ -1075,6 +1096,7 @@ gnutls_certificate_details (gnutls_x509_crt_t cert)
make_string (dn, buf_size)));
xfree (dn);
}
+#endif
/* SubjectPublicKeyInfo. */
{
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Eli Zaretskii, 2018/07/01
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Lars Ingebrigtsen, 2018/07/03
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Noam Postavsky, 2018/07/03
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Lars Ingebrigtsen, 2018/07/08
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Lars Ingebrigtsen, 2018/07/08
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Noam Postavsky, 2018/07/08
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Lars Ingebrigtsen, 2018/07/08
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Noam Postavsky, 2018/07/09
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Lars Ingebrigtsen, 2018/07/22
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Noam Postavsky, 2018/07/29
- bug#31946: 27.0.50; The NSM should warn about more TLS problems,
Lars Ingebrigtsen <=
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Lars Ingebrigtsen, 2018/07/08
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Lars Ingebrigtsen, 2018/07/08
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Lars Ingebrigtsen, 2018/07/08
- bug#31946: 27.0.50; The NSM should warn about more TLS problems, Lars Ingebrigtsen, 2018/07/08