bug#31357: 26.1; tramp-make-tramp-file-name: incompatible lisp changes in 26.1 ?

[Phil Sainty]

In Emacs 25 `tramp-make-tramp-file-name' takes 4-5 arguments:
(method user host localname &optional hop)

In Emacs 26.1 it takes 6-7
(method user domain host port localname &optional hop)

That can then trigger a "wrong-number-of-arguments" error.

This should surely be covered in NEWS under the "Incompatible Lisp
Changes in Emacs 26.1" section?

I rather suspect there were also many other functions affected by
these changes, but I've not attempted to audit that.

I have custom code where I am presently using the following construct
to deal with this.

(if (version< emacs-version "26")
    (tramp-make-tramp-file-name
     method user host localname hop)
  (tramp-make-tramp-file-name
   method user domain host port localname hop))

(With a consequential complaint from the 26.1 byte-compiler about
the first of those two calls.)

Is there a single approach which is backwards-compatible (at least with
Emacs 25) ?

For my specific use-case, what I really wanted was a way to modify only
a specific named component of a tramp file name, but I ended up using
`tramp-dissect-file-name', extracting the components with the various
`tramp-file-name-COMPONENT' functions, and using `tramp-make-file-name'
to put it all back together.  I thought there might be a simpler way to
do this, but I didn't see one.


-Phil




In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll 
bars)
 of 2018-04-15 built on shodan
Windowing system distributor 'The X.Org Foundation', version 
11.0.11804000
System Description:     Ubuntu 16.04.4 LTS

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Mark activated

Configured using:
 'configure --prefix=/home/phil/emacs/26.1rc1/usr/local
 --with-x-toolkit=lucid --without-sound'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK DBUS GSETTINGS NOTIFY
GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 THREADS
LCMS2

Important settings:
  value of $LANG: en_NZ.UTF-8
  locale-coding-system: utf-8

Major mode: Dired by name

Minor modes in effect:
  show-paren-mode: t
  minibuffer-depth-indicate-mode: t
  winner-mode: t
  global-hl-line-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib format-spec rfc822 mml
mml-sec password-cache epa derived epg epg-config gnus-util rmail
rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils dired-x easymenu paren mb-depth winner
ring hl-line dired dired-loaddefs advice elec-pair time-date mule-util
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 100308 9804)
 (symbols 48 20761 2)
 (miscs 40 101 271)
 (strings 32 30242 1161)
 (string-bytes 1 789994)
 (vectors 16 14561)
 (vector-slots 8 496928 9732)
 (floats 8 58 59)
 (intervals 56 269 7)
 (buffers 992 13)
 (heap 1024 44332 1473))