|
From: | Michael Hendricks |
Subject: | bug#31139: [PATCH] Document Narrow indicator in describe-mode |
Date: | Thu, 19 Apr 2018 14:38:08 +0000 |
Okay, I'm convinced. I think adding a comment along the lines of
"narrowing is not a minor mode, but its indicator is part of
mode-line-modes", would be helpful in case someone tries to "fix" your
change later.
> + (when (or (> (point-min) 1) (<= (point-max) (buffer-size)))
You should use buffer-narrowed-p instead of checking point min & max
here.
Have you assigned copyright for Emacs?
[Prev in Thread] | Current Thread | [Next in Thread] |