[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29156: 25.3; eshell/kill does not understand -<signal>, [PATCH] Make

From: Noam Postavsky
Subject: bug#29156: 25.3; eshell/kill does not understand -<signal>, [PATCH] Make eshell/kill handle -<signal> and -<SIGNALNAME>
Date: Thu, 22 Mar 2018 21:05:33 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)

Thanks, do you have copyright assignment for Emacs? (the change is small
enough to install regardless, I'm asking just to know if it should be
marked as a tiny change).

A couple more minor nitpicks:

>      * doc/misc/eshell.texi (kill): Update docs to reflect new
>      function behaviour
>      * etc/NEWS: Mention new eshell/kill behaviour

Missing periods here.

> +          (setq signum (intern (substring arg 1 (length arg))))))

That could be just (substring arg 1)

P.S. don't worry about the forwarding thing, it happens often enough
that I've written an Emacs command to mostly automate it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]