[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#30699: 26.0.91; buffer contents flicker on macOS frames when frames

From: Alan Third
Subject: bug#30699: 26.0.91; buffer contents flicker on macOS frames when frames are resized
Date: Sun, 4 Mar 2018 21:34:04 +0000
User-agent: Mutt/1.9.3 (2018-01-21)

On Sun, Mar 04, 2018 at 08:27:36PM +0000, Alan Third wrote:
> On Sun, Mar 04, 2018 at 09:38:27AM -0800, Aaron Jensen wrote:
> > It appears that (on macOS, at least) when a frame is resized, there is
> > an unsightly flicker. It does not matter if the frame is undecorated or
> > not.
> Simpler repro:
> (dotimes (n 10)
>   (set-frame-parameter nil 'width (+ 80 n))
>   (sit-for 0.1))

It’s the call to SET_FRAME_GARBAGED in EmacsView::updateFrameSize. I
don’t know if it’s needed in this circumstance, but without it it
stops the frame being blanked when resizing with the mouse, which is

The attached patch appears to fix it without breaking mouse resizing,
but it looks like this comment in windowDidResize also counts for macOS:

   /* In GNUstep, at least currently, it's possible to get a didResize
      without getting a willResize.. therefore we need to act as if we got
      the willResize now */

I honestly don’t see that it makes any difference though.

The root problem is actually that we’re unable to execute redisplay
while the frame is being resized by a mouse. The NS event loop goes
into some ‘modal’ state which we can’t break out of, thus preventing
us from doing anything until it’s done. If that didn’t happen we
wouldn’t need to blank the screen at all.
Alan Third

Attachment: 0001-Fix-flicker-when-resizing-frame-on-macOS-bug-30699.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]