[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#30610: clarify linux-mode usage from Lisp

From: John Shahid
Subject: bug#30610: clarify linux-mode usage from Lisp
Date: Sat, 03 Mar 2018 18:17:19 -0500
User-agent: mu4e 1.0-alpha3; emacs 26.0.91

Noam Postavsky <address@hidden> writes:

> John Shahid <address@hidden> writes:
>> Worth noting that this is my first patch to Emacs. Let me know if
>> there's anything wrong with the way I submitted the patch.
> The patch looks fine, but the commit message should have a ChangeLog
> style entry as described in CONTRIBUTE under "Commit messages".

fixed and attached a new patch

> And if you haven't assigned copyright for Emacs, it should also have a
> 'Copyright-paperwork-exempt: yes' line.  Note that we only accept up
> to 15 lines worth of unassigned patches.  If you want to start the
> assignment process, fill out the form at [1] and send it to
> address@hidden (they will reply with further instructions).

i filled out and sent the paper work. i also exempt this commit from the
paperwork since it is a very minor change.



>From 113b30d8739dc8d1673a53d06b201e6c9ea1a54a Mon Sep 17 00:00:00 2001
From: John Shahid <address@hidden>
Date: Sun, 25 Feb 2018 14:33:00 -0500
Subject: [PATCH] lisp/linum.el: clarify linum-mode handling of `ARG'

Copyright-paperwork-exempt: yes
 lisp/linum.el | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lisp/linum.el b/lisp/linum.el
index 9df0c5d023..fa66d62bfe 100644
--- a/lisp/linum.el
+++ b/lisp/linum.el
@@ -76,8 +76,12 @@ linum-delay
 (define-minor-mode linum-mode
   "Toggle display of line numbers in the left margin (Linum mode).
 With a prefix argument ARG, enable Linum mode if ARG is positive,
-and disable it otherwise.  If called from Lisp, enable the mode
-if ARG is omitted or nil.
+and disable it otherwise.
+When called from Lisp, toggles the mode if the argument is
+`toggle', disables the mode if the argument is a non-positive
+integer, and enables the mode otherwise (including if the
+argument is omitted or nil or a positive integer).
 Linum mode is a buffer-local minor mode."
   :lighter ""                           ; for desktop.el

reply via email to

[Prev in Thread] Current Thread [Next in Thread]