[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb
From: |
Michael Albinus |
Subject: |
bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb |
Date: |
Sat, 24 Feb 2018 21:56:51 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Mathieu Othacehe <m.othacehe@gmail.com> writes:
Hi Mathieu,
> Support some Android derived systems where 'ls' binary is provided by
> GNU Coreutils.
Thanks for this! I cannot test myself, so I'll trust that it works
proper. However,
> + ;; Support Android derived systems where "ls" command is provided
> + ;; by GNU Coreutils. Force "ls" to print one column and set
> + ;; time-style to imitate other "ls" flavours.
> + ((tramp-adb-send-command-and-check vec "ls --help | grep coreutils")
> + "env COLUMNS=1 ls --time-style=long-iso")
I believe it is not future-safe to depend on any string in --help
output. The better approach is to test, whether the ls command accepts
the --time-style=long-iso argument. Something like
((tramp-adb-send-command-and-check vec "ls --time-style=long-iso /dev/null")
Could you pls check, whether it works like this?
Best regards, Michael.
- bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb, Mathieu Othacehe, 2018/02/24
- bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb,
Michael Albinus <=
- bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb, Michael Albinus, 2018/02/24
- bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb, Mathieu Othacehe, 2018/02/25
- bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb, Andreas Schwab, 2018/02/25
- bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb, Mathieu Othacehe, 2018/02/25
- bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb, Michael Albinus, 2018/02/25
- bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb, Mathieu Othacehe, 2018/02/25
- bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb, Michael Albinus, 2018/02/26