bug#23753: 25.0.95; configuration of X client fails to include graphics libraries on Mac OS X 10.6.8

[YAMAMOTO Mitsuharu]

>>>>> On Mon, 11 Dec 2017 21:01:23 +0000, Alan Third <alan@idiocy.org> said:

> Yamamoto san, I hope it’s OK to copy you in on this.

> In order to make the NS port of Emacs compile on GCC on macOS we need
> to remove two instances of Objective‐C blocks in macfont.m. It looks
> to me like we can make it run in‐line, i.e. change

>       dispatch_group_async (group, queue, ^{
>           glyphs[i] = kCGFontIndexInvalid;

>           if (default_uvs_offset)
>             {
>               struct default_uvs_table *default_uvs =
>                 (struct default_uvs_table *) ((UInt8 *) uvs


> to just

>       {
>           glyphs[i] = kCGFontIndexInvalid;

>           if (default_uvs_offset)
>             {
>               struct default_uvs_table *default_uvs =
>                 (struct default_uvs_table *) ((UInt8 *) uvs

> As far as I can see this will still work, but we’re not sure whether
> it will cause any problems. Since this is, I believe, your code, do
> you have any thoughts on the matter?

Running it in-line wouldn't cause any problems.  Actually, the Mac
port based on Emacs 23, which supported older systems that lack
libdispatch and blocks, had conditionals to make it in-line for such
systems:

https://bitbucket.org/mituharu/emacs-mac/src/290e18a99605219116728192433f441db15b97e2/src/macfont.c?at=mac-23&fileviewer=file-view-default#macfont.c-812

                                     YAMAMOTO Mitsuharu
                                mituharu@math.s.chiba-u.ac.jp