[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xte
From: |
Alex |
Subject: |
bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode) |
Date: |
Sun, 12 Nov 2017 18:00:57 -0600 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> Perhaps the patch should be replaced on the master branch with one that
>> uses `read-key' in all cases?
>
> Why the rush?
I don't mean to rush anything, but I figured that I should mention it
before I forget about it.
>> > Should we close this bug now, or is there anything else to do with it?
>>
>> The first issue is fixed, but not the second (`mouse-drag-secondary'
>> uses `read-event'). Here's a diff for the second:
>
> If you want this on the release branch, it should be affect only
> xt-mouse. If you propose this for master, see above.
Do you mean that I shouldn't rush the `read-key' change for
`mouse-drag-secondary' in master, either?
Would applying the previous diff for master and the following for
emacs-26 be acceptable?
diff --git a/lisp/mouse.el b/lisp/mouse.el
index 5eeee1ec52..b9ff71402f 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -1740,7 +1740,9 @@ mouse-drag-secondary
(let (event end end-point)
(track-mouse
(while (progn
- (setq event (read-event))
+ (setq event (if (terminal-parameter nil 'xterm-mouse-mode)
+ (read-key)
+ (read-event)))
(or (mouse-movement-p event)
(memq (car-safe event) '(switch-frame select-window))))
- bug#29150: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode), Alex, 2017/11/05
- bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode), Olaf Rogalsky, 2017/11/05
- bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode), Eli Zaretskii, 2017/11/06
- bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode), Olaf Rogalsky, 2017/11/06
- bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode), Eli Zaretskii, 2017/11/11
- bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode), Alex, 2017/11/12
- bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode), Eli Zaretskii, 2017/11/12
- bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode),
Alex <=
- bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode), Eli Zaretskii, 2017/11/13
- bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode), Olaf Rogalsky, 2017/11/13
- bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode), Eli Zaretskii, 2017/11/13
- bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode), Olaf Rogalsky, 2017/11/13
- bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode), Stefan Monnier, 2017/11/12
bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode), Alex, 2017/11/08