bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27653: Patch for bug#27653: 25.2; ses.el text cell justification


From: Eli Zaretskii
Subject: bug#27653: Patch for bug#27653: 25.2; ses.el text cell justification
Date: Thu, 05 Oct 2017 13:09:31 +0300

> From: Gemini Lasswell <gazally@runbox.com>
> Cc: Miroslav Urbanek <mu@miroslavurbanek.com>,  27653@debbugs.gnu.org
> Date: Sat, 30 Sep 2017 11:11:40 -0700
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Could you please provide a minimal recipe, starting from "emacs -Q",
> > that could be used to reproduce the problem?
> 
> >From emacs -Q:
> 
> C-x C-f abc.ses RET
> " abc RET
> 
> Result: The text is left justified.
> 
> I looked through those and found a change in df5703a00d which looked
> like a likely suspect. Reverting it fixes the bug. It looks to me like
> the only thing the change affects is justification of text cells, but
> someone who is familiar with ses.el should have a look at it.

Stefan, the change in ses-print-cell that causes this bug is not
mentioned in the log message of df5703a00d.  Can you tell why you made
that change?

> >From da3b761e2e5fb10f1512befb7399a198e2419faa Mon Sep 17 00:00:00 2001
> From: Gemini Lasswell <gazally@runbox.com>
> Date: Sat, 30 Sep 2017 10:31:25 -0700
> Subject: [PATCH] * lisp/ses.el (ses-print-cell): Fix alignment of text cells
>  (bug#27653)
> 
> ---
>  lisp/ses.el | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lisp/ses.el b/lisp/ses.el
> index 9221476e7a..4c19c70c5d 100644
> --- a/lisp/ses.el
> +++ b/lisp/ses.el
> @@ -1254,8 +1254,7 @@ ses-print-cell
>        ((< len width)
>         ;; Fill field to length with spaces.
>         (setq len  (make-string (- width len) ?\s)
> -             text (if (or (stringp value)
> -                          (eq ses-call-printer-return t))
> +             text (if (eq ses-call-printer-return t)
>                        (concat text len)
>                      (concat len text))))
>        ((> len width)
> -- 
> 2.14.1
> 





reply via email to

[Prev in Thread] Current Thread [Next in Thread]