bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#28451: 26.0.50; copy-directory no longer creates parent directories


From: Paul Eggert
Subject: bug#28451: 26.0.50; copy-directory no longer creates parent directories of target if they do not exist
Date: Sun, 17 Sep 2017 13:15:47 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

Andrew Christianson wrote:
-            (make-directory newname t)))
+            (make-directory newname t))
+            ((and copy-contents (not (file-directory-p newname)))
+             (make-directory newname parents)))

Thanks for clarifying the test case and for the proposed patch. I reproduced the bug on Fedora 26 and wrote a test case to test case for the bug. Although the abovementioned patch should work on Fedora, it won't work on platforms that do not allow trailing / on mkdir arguments. So I installed the attached patch into the emacs-26 branch, and am boldly marking this bug as fixed. Please give it a try.

Attachment: 0001-Fix-recently-introduced-copy-directory-bug.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]