[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28412: Acknowledgement (26.0.50; Let save-some-buffers accept write-
From: |
Eric Abrahamsen |
Subject: |
bug#28412: Acknowledgement (26.0.50; Let save-some-buffers accept write-contents-functions) |
Date: |
Mon, 11 Sep 2017 14:41:08 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
> Thanks. Can we have some simple tests for this, both with and without
> visiting a file?
Is this sufficient, do you think?
(ert-deftest files-test-no-file-write-contents ()
"Test that `write-contents-functions' permits saving a file.
Usually `basic-save-buffer' will prompt for a file name if the
current buffer has none. It should first call the functions in
`write-contents-functions', and if one of them returns non-nil,
consider the buffer saved, without prompting for a file
name (Bug#28412)."
(let ((read-file-name-function
(lambda (&rest _ignore)
(error "Prompting for file name"))))
;; With contents function, and no file.
(with-temp-buffer
(setq write-contents-functions
(list (lambda () t)))
(set-buffer-modified-p t)
(should (null (save-buffer))))
;; With no contents function and no file. This should reach the
;; `read-file-name' prompt.
(with-temp-buffer
(set-buffer-modified-p t)
(should-error (save-buffer) :type 'error))
;; Then a buffer visiting a file: should save normally.
(files-tests--with-temp-file temp-file-name
(with-current-buffer (find-file-noselect temp-file-name)
(setq write-contents-functions nil)
(insert "p")
(should (null (save-buffer)))
(should (eq (buffer-size) 1))))))
bug#28412: 26.0.50; Let save-some-buffers accept write-contents-functions, Kaushal Modi, 2017/09/18
bug#28412: 26.0.50; Let save-some-buffers accept write-contents-functions, Eric Abrahamsen, 2017/09/18
bug#28412: 26.0.50; Let save-some-buffers accept write-contents-functions, Kaushal Modi, 2017/09/18
bug#28412: 26.0.50; Let save-some-buffers accept write-contents-functions, Eric Abrahamsen, 2017/09/18