bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27840: 26.0.50; vc-git-grep stopped working on git master


From: npostavs
Subject: bug#27840: 26.0.50; vc-git-grep stopped working on git master
Date: Sun, 30 Jul 2017 14:08:20 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux)

Dmitry Gutov <address@hidden> writes:

> On 7/27/17 2:32 AM, address@hidden wrote:
>
>> Perhaps we should
>> instead disable this option by default; when I introduced it, I didn't
>> think about the fact that grep.el is used for not-quite-grep programs as
>> well.
>
> Or we can try to think of them as separate. I.e., the patch below also
> works.

Right, but the question is: are there n+1 other places where we will
need to do this?

> And if we want to use the --null option for vc-git-grep, we can
> construct a derivative alist in vc-git.el.
>
> Up to you, of course.
>
>       (let ((default-directory dir)
> -           (compilation-environment (cons "PAGER=" compilation-environment)))
> +           (compilation-environment (cons "PAGER=" compilation-environment))
> +              grep-use-null-filename-separator)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]