bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24543: 25.1; describe-symbol doesn't show face with same name as a v


From: Alex
Subject: bug#24543: 25.1; describe-symbol doesn't show face with same name as a variable
Date: Fri, 28 Jul 2017 14:45:24 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> From: Alex <address@hidden>
>> Date: Fri, 16 Jun 2017 15:54:45 -0600
>> 
>> > emacs -Q
>> > C-h o font-lock-comment-face RET
>> >
>> > Only the variable of this name is shown, not the face (which can be
>> > viewed with describe-face, of course).
>> >
>> > It appears that when the face only shares a name with a function, then
>> > both the function and face are shown. Only a variable shadows the face
>> > in describe-symbol.
>> 
>> This is because describe-symbol isn't returning (buffer-string) like
>> describe-{function, variable} are.
>> 
>> I've attached a patch fixing this problem.
>
> Thanks.  This LGTM, but doesn't the fact that describe-face's return
> value will change after this constitute an incompatible change?  And

I suppose so; would it be expected to be documented in NEWS?

> if so, could it break some of the users of this function out there?

Potentially, but I don't see that being an issue in this case. The
return value isn't documented, so users shouldn't be (and likely aren't)
relying on describe-face always returning nil. It makes more sense to
treat describe-face like describe-{function, variable}.

Though I'm not sure why those two procedures return (buffer-string) in
the first place. In any case, I figure it's better to leave those and
describe-symbol alone and just make describe-face behave similarly.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]