bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27817: 26.0.50; Dired: Support eshell/ls from the beginning if user


From: Eli Zaretskii
Subject: bug#27817: 26.0.50; Dired: Support eshell/ls from the beginning if user want to
Date: Tue, 25 Jul 2017 17:33:48 +0300

> From: Tino Calancha <address@hidden>
> Date: Tue, 25 Jul 2017 15:52:29 +0900
> 
> commit 6322f2932e9a083e01bb86aa219fc8256443c33f
> Author: Tino Calancha <address@hidden>
> Date:   Tue Jul 25 15:46:54 2017 +0900
> 
>     Dired: Support eshell/ls from the beginning if user want to
>     
>     * lisp/dired.el (dired-insert-directory): Check for em-ls as well.
>     * test/lisp/dired-tests.el (dired-test-bug27817): Add test.

Looks okay, but (a) please cite the bug number in the commit log
message, and (b) shouldn't this:

> +         (not (and (featurep 'eshell) (bound-and-true-p 
> eshell-ls-use-in-dired)))
                                                           
^^^^^^^^^^^^^^^^^^^^^^

quote eshell-ls-use-in-dired?

Thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]