[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#27243: closed (Re: bug#27243: dired-auto-revert-buffer jumps point t
bug#27243: closed (Re: bug#27243: dired-auto-revert-buffer jumps point to beginning of buffer)
Sat, 15 Jul 2017 13:14:06 +0200
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)
On Fri, 14 Jul 2017 22:52:18 -0700 John Wiegley <address@hidden> wrote:
>>>>>> Stephen Berman <address@hidden> writes:
>> Thanks for confirming. I think this is the right fix and would commit it,
>> but since this exchange has taken place in a closed bug, it may have fallen
>> under the radar, so I'd like an explicit go-ahead. Eli, John?
> At first glance it looks OK to me, though I defer to Eli's experience in such
On Sat, 15 Jul 2017 10:18:06 +0300 Eli Zaretskii <address@hidden> wrote:
> No objections here.
Thanks for okaying, but...
On Sat, 15 Jul 2017 09:36:41 +0200 martin rudalics <address@hidden> wrote:
>> + (set-window-buffer (selected-window)
>> + (set-buffer (dired-noselect dirname switches))))
> This really should be
> (pop-to-buffer-same-window (dired-noselect dirname switches))
> Even if people disliked it in the past and some still dislike it: Try
> C-h f
> M-x dired
Wow, that's disastrous! And frightening: I use the "(set-window-buffer
(selected-window) (set-buffer ...))" idiom a lot in todo-mode.el; I just
checked two commands using `C-h f' followed by the command invocation:
one worked fine but the other caused the same disaster. So now I have
to check all uses :(. Is there a general guideline for when to use
set-window-buffer and when to use pop-to-buffer-same-window?
Anyway, I'll commit the dired.el change you recommend; many thanks.