[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Mon, 3 Jul 2017 05:11:30 +0300
Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0
On 7/1/17 2:23 PM, Ingo Lohmar wrote:
I hope I understood the manual/indent idea correctly. Below is the
updated patch including a test file.
Looks good, thanks.
I changed the variable name to `js-indent-cont-nonempty-aligned' now
(with "flipped" boolean meaning, as discussed before). This is more
succinct and starts with `js-indent-...' to convey the feature area to
which this setting belongs.
OK, it seems better. Still requires effort to decipher the meaning,
though. I don't have any better suggestions, so might as well commit
What's the procedure for patches arising from a bug report --- should I
add a NEWS entry (for 26.1, marked +++) and just commit this to master
When a reviewer says "Looks good, please install", or you're feeling
confident yourself, yes. On that note, LGTM, please install. :)
A NEWS entry for the new variable is a good idea. But "+++" means "all
necessary documentation updates are complete". "---", meaning "no change
in the manuals is needed", seems more appropriate.