[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27202: 26.0.50; Eldoc mode is broken

From: Dmitry Gutov
Subject: bug#27202: 26.0.50; Eldoc mode is broken
Date: Sat, 3 Jun 2017 02:05:49 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0

On 6/3/17 1:47 AM, Stephen Berman wrote:

Boostrapping latest master didn't fix it here.

I manually reverted this part of 2349f1df1b:

So basically all of it.

-(define-minor-mode global-eldoc-mode
-  "Toggle Global Eldoc mode on or off.
-With a prefix argument ARG, enable Global Eldoc mode if ARG is
-positive, and disable it otherwise.  If called from Lisp, enable
-the mode if ARG is omitted or nil, and toggle it if ARG is ‘toggle’.
-If Global Eldoc mode is on, `eldoc-mode' will be enabled in all
-buffers where it's applicable.  These are buffers that have modes
-that have enabled eldoc support.  See `eldoc-documentation-function'."
+(define-globalized-minor-mode global-eldoc-mode eldoc-mode turn-on-eldoc-mode
    :group 'eldoc
-  :global t
    :initialize 'custom-initialize-delay
-  :init-value t
-  (setq eldoc-last-message nil)
-  (if global-eldoc-mode
-      (progn
-       (add-hook 'post-command-hook #'eldoc-schedule-timer)
-       (add-hook 'pre-command-hook #'eldoc-pre-command-refresh-echo-area))
-    (remove-hook 'post-command-hook #'eldoc-schedule-timer)
-    (remove-hook 'pre-command-hook #'eldoc-pre-command-refresh-echo-area)))
+  :init-value t)

then rebuilt Emacs (just make, not bootstrap), and now Eldoc in the
modeline works here again.

Do you have an explanation why one version of the code works, and another doesn't?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]