bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27122: 26.0.50; [PATCH] Add customizable to display unprintables as


From: Robert Cochran
Subject: bug#27122: 26.0.50; [PATCH] Add customizable to display unprintables as hex
Date: Mon, 29 May 2017 17:47:49 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

npostavs@users.sourceforge.net writes:

> While I'm also okay with changing this to hex display without an option,
> I don't think that commit introduced the octal behaviour, it just
> changed the implementation.  I think these these removed lines used to
> do it:
>
> -                 /* Insert three more glyphs into IT->ctl_chars for
> -                    the octal display of the character.  */
> -                 g = ((str[i] >> 6) & 7) + '0';
> -                 XSETINT (it->ctl_chars[i * 4 + 1], g);
> -                 g = ((str[i] >> 3) & 7) + '0';
> -                 XSETINT (it->ctl_chars[i * 4 + 2], g);
> -                 g = (str[i] & 7) + '0';
> -                 XSETINT (it->ctl_chars[i * 4 + 3], g);

Indeed. I wasn't looking closely enough. I mentally skipped over that
part because it was below the new sprintf. My bad, thanks for catching
that.

-- 
~Robert Cochran

GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26  AD2D E5C3 EB36 4886 8871





reply via email to

[Prev in Thread] Current Thread [Next in Thread]