[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26378: 26.0.50; Hitting 'n' during ediff gives Error
From: |
npostavs |
Subject: |
bug#26378: 26.0.50; Hitting 'n' during ediff gives Error |
Date: |
Wed, 05 Apr 2017 19:23:14 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Now that we're looking at the whole thing, I have a few more comments.
Kaushal Modi <kaushal.modi@gmail.com> writes:
> + "Execute the diff PROGRAM.
> +
> +The PROGRAM output is sent to BUFFER, which must be a buffer object,
> +and must be alive.
It would flow a bit better to say "which must be a live buffer object".
> +
> +The PROGRAM is executed asynchronously unless the OS is OS/2,
> +Windows-*, or DOS, or unless SYNCH is non-nil.
I don't see any reference to OS/2 in the code, so I think we should just
drop it. And I'm not sure what the "-*" in "Windows-*" means; I think
we should just say "unless `system-type' is `windows-nt' or `ms-dos'".
> +
> +OPTIONS is a list of options to pass to PROGRAM. It may be a blank
> +string.
This seems to be wrong, OPTIONS is not a list. It should say "OPTIONS
is a string of space-separated options to pass to PROGRAM".
> +
> +An element in FILES must be either a string or nil.
> +
> +We also delete nil and \"\" from all arguments."
I think these last 2 sentences should be combined into something like:
"FILES is a list of filenames to pass to PROGRAM; nil and \"\" elements
are ignored."
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/05
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/05
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/05
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Noam Postavsky, 2017/04/05
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/05
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error,
npostavs <=
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/06
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, npostavs, 2017/04/06
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/06
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, npostavs, 2017/04/06
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/07
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, npostavs, 2017/04/07
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Philipp Stephani, 2017/04/08
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/10