bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25792: 26.0.50; Scroll-margin working incorrectly when scrolling dow


From: npostavs
Subject: bug#25792: 26.0.50; Scroll-margin working incorrectly when scrolling down if show-trailing-whitespace is t
Date: Mon, 20 Feb 2017 13:46:02 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

tags 25792 patch
quit

Eli Zaretskii <address@hidden> writes:

>> From: address@hidden
>> Cc: address@hidden,  address@hidden
>> Date: Mon, 20 Feb 2017 12:42:58 -0500
>> 
>> The difference seems to be that try_window returns -1 in the case where
>> we correctly stay out of the margin, but 1 in the case where we cross
>> into it.  I tried adding a partial_line_height call, but it's not giving
>> the right answer.  The move_it_to (&it, ZV, -1, it.last_visible_y, -1,
>> MOVE_TO_POS | MOVE_TO_Y) call doesn't stop at last_visible_y, it goes to
>> the end of buffer, so the returned partial height is a very large number
>> (approx 6500 in my test).
>
> Probably because it.current_y is already beyond it.last_visible_y, due
> to the loop before the call:

Ah, right.

> Does it work to call start_display again, before the call to
> partial_line_height?

Yes, here's a patch:

>From f3f948057ae78a551a2f83d89f7918623bed3e6e Mon Sep 17 00:00:00 2001
From: Noam Postavsky <address@hidden>
Date: Mon, 20 Feb 2017 13:34:39 -0500
Subject: [PATCH v1] Fix scrolling with partial line corner case (Bug#25792)

* src/xdisp.c (try_window): Take partial line height into account when
comparing cursor position against scroll margin.
---
 src/xdisp.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/xdisp.c b/src/xdisp.c
index e59934d2d5..6c94147844 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -17376,21 +17376,27 @@ try_window (Lisp_Object window, struct text_pos pos, 
int flags)
        return 0;
     }
 
+  /* Save the character position of 'it' before we call
+     'start_display' again.  */
+  ptrdiff_t it_charpos = IT_CHARPOS (it);
+
   /* Don't let the cursor end in the scroll margins.  */
   if ((flags & TRY_WINDOW_CHECK_MARGINS)
       && !MINI_WINDOW_P (w))
     {
       int this_scroll_margin = window_scroll_margin (w, MARGIN_IN_PIXELS);
+      start_display (&it, w, pos);
 
       if ((w->cursor.y >= 0    /* not vscrolled */
           && w->cursor.y < this_scroll_margin
           && CHARPOS (pos) > BEGV
-          && IT_CHARPOS (it) < ZV)
+           && it_charpos < ZV)
          /* rms: considering make_cursor_line_fully_visible_p here
             seems to give wrong results.  We don't want to recenter
             when the last line is partly visible, we want to allow
             that case to be handled in the usual way.  */
-         || w->cursor.y > it.last_visible_y - this_scroll_margin - 1)
+          || w->cursor.y > (it.last_visible_y - partial_line_height (&it)
+                            - this_scroll_margin - 1))
        {
          w->cursor.vpos = -1;
          clear_glyph_matrix (w->desired_matrix);
@@ -17399,7 +17405,7 @@ try_window (Lisp_Object window, struct text_pos pos, 
int flags)
     }
 
   /* If bottom moved off end of frame, change mode line percentage.  */
-  if (w->window_end_pos <= 0 && Z != IT_CHARPOS (it))
+  if (w->window_end_pos <= 0 && Z != it_charpos)
     w->update_mode_line = true;
 
   /* Set window_end_pos to the offset of the last character displayed
-- 
2.11.1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]