bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el


From: Charles A. Roelli
Subject: bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el
Date: Sat, 18 Feb 2017 12:20:02 +0100

`mouse-1' is bound in debbugs-gnu.el, which means that a nil value of
`mouse-1-click-follows-link' is not respected.  The following patch is
needed:

--- debbugs-0.12/debbugs-gnu.el.~2~     2017-02-17 17:54:15.000000000 +0100
+++ debbugs-0.12/debbugs-gnu.el         2017-02-18 12:07:56.000000000 +0100
@@ -909,7 +909,6 @@
        (menu-map (make-sparse-keymap)))
     (set-keymap-parent map tabulated-list-mode-map)
     (define-key map "\r" 'debbugs-gnu-select-report)
-    (define-key map [mouse-1] 'debbugs-gnu-select-report)
     (define-key map [mouse-2] 'debbugs-gnu-select-report)
     (define-key map "g" 'debbugs-gnu-rescan)
     (define-key map "R" 'debbugs-gnu-show-all-blocking-reports)
@@ -1587,7 +1586,6 @@
   (let ((map (make-sparse-keymap)))
     (set-keymap-parent map tabulated-list-mode-map)
     (define-key map "\r" 'debbugs-gnu-select-usertag)
-    (define-key map [mouse-1] 'debbugs-gnu-select-usertag)
     (define-key map [mouse-2] 'debbugs-gnu-select-usertag)
     map))

There already was a ChangeLog entry to this effect in the past:

2012-12-23  Lars Ingebrigtsen  <address@hidden>

        Don't explicitly bind mouse-1.

        As Michael Heerdegen <address@hidden> says:

        However, also binding mouse-1 is not necessary.  Depending on the 
        setting of `mouse-1-click-follows-link', which is non-nil by default, 
        mouse-1 already follows links - see its doc.  We should leave it up to 
        the user if he wants to use mouse-1 for following or not.

But the change does not seem to have been made, or maybe it was reverted
at some point.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]