bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25612: 26.0.50; Slightly suboptimal message for disabled commands


From: Philipp Stephani
Subject: bug#25612: 26.0.50; Slightly suboptimal message for disabled commands
Date: Sun, 12 Feb 2017 15:12:31 +0000



Eli Zaretskii <address@hidden> schrieb am Fr., 10. Feb. 2017 um 10:00 Uhr:
> Date: Fri, 03 Feb 2017 23:16:27 +0200
> From: Eli Zaretskii <address@hidden>
> Cc: address@hidden
>
> > From: Philipp Stephani <address@hidden>
> > Date: Fri, 03 Feb 2017 15:54:06 +0000
> > Cc: address@hidden
> >
> >  Yes, this-command-keys returns just "^M" instead of the expected
> >  "\370erase-buffer^M" it returned in Emacs 24.2 and older.
> >
> > git bisect says
> >
> > b593d6a999b21dfee6939b24866a5ec6fbe7d11b is the first bad commit
> > commit b593d6a999b21dfee6939b24866a5ec6fbe7d11b
> > Author: Aaron S. Hawley <address@hidden>
> > Date: Tue May 1 12:10:02 2012 -0400
> >
> > Reimplement execute-extended-command in Elisp.
> > * src/keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
> > Move to simple.el.
> > * lisp/simple.el (suggest-key-bindings, execute-extended-command):
> > Move from keyboard.c.
>
> Yes, when execute-extended-command was reimplemented in Lisp, the
> special code which produced "\370erase-buffer^M" was lost.
>
> Does the change below produce good results?  If so, can anyone suggest
> a more elegant way of squirreling M-x into this-command-keys?

No further comments, so I pushed my kludgey solution, and I'm marking
this bug done.


Sorry for not responding earlier, the fix works fine. My only nitpick would be to add a comment for the magic number 248 in the code. I can guess it's 0x80 | 'x', but that might not be obvious to casual readers. 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]