bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#21804: 25.0.50; file-notify-tests failure on Cygwin


From: Ken Brown
Subject: bug#21804: 25.0.50; file-notify-tests failure on Cygwin
Date: Thu, 29 Dec 2016 15:33:15 -0500
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

Hi Michael,

On 12/29/2016 2:06 PM, Michael Albinus wrote:
> Ken Brown <address@hidden> writes:
> I've added the new function Fgfile_monitor_name to gfilenotify.c. It
> tells us the name of the used monitor. In my case (GNU/Linux), it is
> GInotifyFileMonitor. In your case it is GPollFileMonitor.

Actually it turns out to be GFamFileMonitor on my system, presumably because I 
have the gamin package installed.  I'm going to see if I can figure out how 
GFamFileMonitor works.  As a quick check, however, I applied the following 
patch...

--- a/test/lisp/filenotify-tests.el
+++ b/test/lisp/filenotify-tests.el
@@ -73,7 +73,8 @@ file-notify--test-read-event
     ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5. So we must
     ;; wait at least this time.
     ((and (string-equal (file-notify--test-library) "gfilenotify")
-         (string-equal (file-notify--test-monitor) "GPollFileMonitor"))
+          (or (string-equal (file-notify--test-monitor) "GPollFileMonitor")
+              (string-equal (file-notify--test-monitor) "GFamFileMonitor")))
      7)
     ((file-remote-p temporary-file-directory) 0.1)
     (t 0.01))))

...and all the inexpensive tests passed.  I'll keep playing with this.

> PS: Could you pls provide on your site a recompiled Emacs? I would like
> to use the changed gfilenotify.c. Thanks!

It's building right now and should be available shortly.

Best regards,

Ken





reply via email to

[Prev in Thread] Current Thread [Next in Thread]