|Subject:||bug#18133: Suppressing asynchronous command output|
|Date:||Tue, 27 Dec 2016 22:21:11 +0000|
> From: Reuben Thomas <address@hidden>
> Date: Tue, 27 Dec 2016 09:01:32 +0000
> Cc: Juri Linkov <address@hidden>, martin rudalics <address@hidden>, address@hidden
> > +(defun comint-make-newly-written-
buffer-visible (string process)I don't see it hard-coded in any context such as this.
> > + "Make the output buffer visible when output is added to an empty buffer.
> > +Useful in `comint-preoutput-filter-
> > + (let ((buffer (process-buffer process)))
> > + (when (and (= 0 (buffer-size buffer))
> > + (string-match-p "\\*Async Shell Command\\*"
> > + (buffer-name buffer)))
> > + (display-buffer (process-buffer process))))
> > + string)
> Why are we hard-coding a certain buffer name in a function that is
> supposed to be more general, judging by its name and doc string?
> I found it hard-coded several times in other places, so I hard-coded it here. What do you suggest?
I think the regexp against which buffer names are matched in
buffer-visible should be customizable, with
"*Async Shell Command*" being (in) the default value.
And another question: where's the user option to turn this feature on
or off (including the default being off)?
|[Prev in Thread]||Current Thread||[Next in Thread]|