bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25215: 25.1.90; js--proper-indentation is affected by the value of f


From: Eli Zaretskii
Subject: bug#25215: 25.1.90; js--proper-indentation is affected by the value of forward-sexp-function
Date: Fri, 16 Dec 2016 23:02:38 +0200

> From: Dmitry Gutov <address@hidden>
> Date: Fri, 16 Dec 2016 14:58:35 +0200
> 
> js2-mode derives from js-mode and, starting with Emacs 25.1, inherits
> its indentation function.
> 
> However, forward-sexp-function in js2-mode can be slow because it uses
> the AST, and when the current parsing pass had been interrupted by user
> input, it's forced to finish. Which is slow in large files.
> 
> And its subtleties aren't really needed by the intentation code. So in
> the various bits of code we've brought over from js2-mode we have kept
> the forward-sexp-function->nil binding.
> 
> We've missed it in js--multi-line-declaration-indentation, hovewer. And
> in js--maybe-goto-declaration-keyword-end (though that one only comes
> into play with a non-default value of js-indent-first-init).
> 
> The patch is below.

Thanks, this is okay for the release branch.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]