|Subject:||bug#25172: 26.0.50; Concurrency feature, sit-for doesn't work (crashing and unexpected behaviour)|
|Date:||Fri, 16 Dec 2016 00:28:03 +0800|
> From: Elias Mårtenson <address@hidden>
> Date: Thu, 15 Dec 2016 11:30:54 +0800
> After applying that patch, it hasn't crashed yet. So either it fixes the problem, or it's simply buch harder toThanks, I pushed it now.
> reproduce. So far so good. Thanks a lot!
> I want to note that the thing that seems to fix it is the application of the most recent suggestion.
> suggestion (removing the calls to clock_input ()/unblock_input()) it
> In other words, if I roll back the application of the previous
> still seems to be stable.Yes, it turns out acquiring Glib context is thread-safe (it uses a
mutex internally), so only one thread can ever acquire it. Not
calling Glib functions when we failed to acquire context avoids both
the crashes in Glib and calling block_input/unblock_input from more
than one thread.
I guess we can now close this bug?
Thanks so much for your help in debugging this.
|[Prev in Thread]||Current Thread||[Next in Thread]|