[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25128: Reorder lisp.h to declare types before using them

From: Paul Eggert
Subject: bug#25128: Reorder lisp.h to declare types before using them
Date: Tue, 6 Dec 2016 23:19:19 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

Tags: patch

Attached is a patch to reorder src/lisp.h so that more types are declared before use. The main motivation is to eventually add support for -fcheck-pointer-bounds; future changes will need access to type sizes (e.g., XCONS might need sizeof (struct Lisp_Cons)), which should be easy after this change. Also, the change shortens lisp.h a bit and (if you ask me) makes it easier to read, since the basic functions for a type are now declared next to the type.

I would like to install this soon, and am posting this as a bug report to give Eli and others a heads-up, in case some MS-Windows module now needs to include process.h. This may be needed because XPROCESS is now defined in process.h instead of lisp.h; similarly for buffer.h, window.h, termhooks.h.

Attachment: 0001-Reorder-lisp.h-to-declare-types-before-using-them.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]