[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25091: 26.0.50; shr-map hides gnus-article keys
From: |
Katsumi Yamaoka |
Subject: |
bug#25091: 26.0.50; shr-map hides gnus-article keys |
Date: |
Mon, 05 Dec 2016 15:57:12 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (i686-pc-cygwin) |
On Fri, 02 Dec 2016 21:26:20 -0500, npostavs@users.sourceforge.net wrote:
> There's a similar attempt in yasnippet to try use the original binding.
> It's generally been troublesome.
I realized it is not a coincidence that two TAB commands, one is
provided by `gnus-article-mode-map' and the other is provided by
`shr-map', behave similarly in the Gnus article buffer. Why TAB
-- `widget-forward' -- moves the point to a shr link in addition
to attachment buttons is because Gnus adds widget buttons to shr
links purposely using `mm-convert-shr-links' (see mm-decode.el).
So, I believe it is natural to make `shr-next-link' behave like
`widget-forward' as well. Furthermore, what should make it do so
should be `mm-convert-shr-links', not shr functions (as a patch
I posted first). In other words, the command that TAB invokes
on a widget button added to a shr link should be `widget-forward',
not `shr-next-link'.
,---- background
| Normally TAB in the Gnus article buffer runs `widget-forward'
| that moves point to the next attachment button or a shr link.
| However, TAB on a shr link in the Gnus article buffer runs
| `shr-next-link' that moves point to only the next shr link.
| So is `shr-previous-link'.
`----
A new patch is below.
> I'm planning to switch it to use a conditional binding as described at [1].
> (define-key <map> <key>
> `(menu-item "" <my-cmd> :filter ,(lambda (cmd) (if <my-predicate> cmd))))
> [1]:
> http://stackoverflow.com/questions/16090517/elisp-conditionally-change-keybinding/22863701#22863701
Thanks. But this case seems to not necessarily be related.
--- mm-decode.el~ 2016-07-25 23:45:06.237009600 +0000
+++ mm-decode.el 2016-12-05 06:55:13.007620000 +0000
@@ -1859,6 +1859,10 @@
(dolist (key (where-is-internal #'widget-button-click widget-keymap))
(unless (lookup-key keymap key)
(define-key keymap key #'ignore)))
+ ;; Avoid `shr-next-link' and `shr-previous-link' so as to run
+ ;; `widget-forward' and `widget-backward' instead.
+ (substitute-key-definition 'shr-next-link nil keymap)
+ (substitute-key-definition 'shr-previous-link nil keymap)
(dolist (overlay (overlays-at start))
(overlay-put overlay 'face nil))
(setq start end)))))