bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25025: python-shell-calculate-command is wrong


From: Eli Zaretskii
Subject: bug#25025: python-shell-calculate-command is wrong
Date: Fri, 02 Dec 2016 16:51:15 +0200

> From: Noam Postavsky <address@hidden>
> Date: Fri, 2 Dec 2016 09:16:04 -0500
> Cc: address@hidden, Clément Pit--Claudel <address@hidden>
> 
> On Fri, Dec 2, 2016 at 2:35 AM, Eli Zaretskii <address@hidden> wrote:
> >> --- a/lisp/progmodes/python.el
> >> +++ b/lisp/progmodes/python.el
> >> @@ -2379,7 +2379,7 @@ python-shell-internal-get-process-name
> >>  (defun python-shell-calculate-command ()
> >>    "Calculate the string used to execute the inferior Python process."
> >>    (format "%s %s"
> >> -          (shell-quote-argument python-shell-interpreter)
> >> +          (combine-and-quote-strings (list python-shell-interpreter))
> >>            python-shell-interpreter-args))
> >
> > Isn't combine-and-quote-strings wrong for quoting shell commands?
> > AFAIR, it doesn't DTRT with some special characters that can appear in
> > file names on Unix.  Am I mistaken?
> 
> It's not a shell command though, hence this bug.

No, but the code in question generates a shell command, from the file
name of the interpreter and its arguments.  Right?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]