[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24
From: |
Eli Zaretskii |
Subject: |
bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24 |
Date: |
Tue, 15 Nov 2016 17:20:36 +0200 |
> From: Sean Whitton <spwhitton@spwhitton.name>
> Date: Mon, 14 Nov 2016 21:00:50 -0700
> Cc: Sean Whitton <spwhitton@spwhitton.name>
>
> The function `map-length' is not available.
> ---
> packages/seq/tests/seq-tests.el | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/packages/seq/tests/seq-tests.el b/packages/seq/tests/seq-tests.el
> index 53930fa..7a9a452 100644
> --- a/packages/seq/tests/seq-tests.el
> +++ b/packages/seq/tests/seq-tests.el
> @@ -351,6 +351,7 @@ Evaluate BODY for each created sequence.
> ["xxx" "xx" "x"]))))
>
> (ert-deftest test-seq-random-elt-take-all ()
> + (skip-unless (version> emacs-version "25"))
> (let ((seq '(a b c d e))
> (count '()))
> (should (= 0 (map-length count)))
A better test is to use fboundp (after requiring the package that
should define it) to probe whether the function exists or not, instead
of relying on the version.
Thanks.
- bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24, Sean Whitton, 2016/11/15
- bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24,
Eli Zaretskii <=
- bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24, Sean Whitton, 2016/11/15
- bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24, Nicolas Petton, 2016/11/15
- bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24, Sean Whitton, 2016/11/15
- bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24, Nicolas Petton, 2016/11/15
- bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24, Sean Whitton, 2016/11/15
- bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24, Nicolas Petton, 2016/11/15
- bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24, Sean Whitton, 2016/11/15
- bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24, Nicolas Petton, 2016/11/16