[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24725: 25.1.50; vc-region-history may exceed max line number of file
|
From: |
Tino Calancha |
|
Subject: |
bug#24725: 25.1.50; vc-region-history may exceed max line number of file in repository |
|
Date: |
Thu, 20 Oct 2016 19:44:54 +0900 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 20.10.2016 11:09, Tino Calancha wrote:
>
>>> Shouldn't that be fixed in the caller, and lto always be decremented if
>>> the regions ends at bol?
>> I think you are right. Otherwise we are including a line out of the
>> region, i.e., in interactive calls we also search in the history for
>> a line out of the highlighted region.
>> How about following new patch?
>
> LGTM, please install.
>
> Although I was thinking of simplifying it to just:
>
> (line-number-at-pos (1- to))
>
> That can only bite us if TO is at bob, which would be very unusual.
Good. It sounds more simple.
Pushed that simple fix to emacs-25 branch as commit 3877c911