bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24585: 25.1; avoid hack in ggtags.el to run compilation-auto-jump ti


From: Stefan Monnier
Subject: bug#24585: 25.1; avoid hack in ggtags.el to run compilation-auto-jump timer
Date: Mon, 03 Oct 2016 09:24:50 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux)

>> IIUC this patch just changes the ordering for same-time timers.
>> Relying on either ordering is itself a hack.  We need a better solution.
> If you eval (progn (run-with-timer 0 ...)  ; timer 1
>                    (run-with-timer 0 ...)) ; timer 2
> you expect timer 1 to be triggered first, no?

Not really.  I think any code which relies on such a property will
sooner suffer.

>> What are those two timers whose relative execution order matters?
>> Why do they care in which order they're run?
> The first timer is compilation-auto-jump which is installed (by compile)
> at the start of compilation.
> The second timer is a cleanup timer which is installed (by ggtags) when
> compilation finishes and there is 0 or 1 match.
> The second timer kills the buffer (among other things) that the first
> timer depends on.

So we can fix the bug by making the timer's code check if the buffer is
still live?


        Stefan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]