[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24378: [PATCH 1/6] Don’t use FETCH_MULTIBYTE_CHAR when advancing ind
From: |
Michal Nazarewicz |
Subject: |
bug#24378: [PATCH 1/6] Don’t use FETCH_MULTIBYTE_CHAR when advancing index |
Date: |
Tue, 06 Sep 2016 17:17:30 +0200 |
User-agent: |
Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.106 (x86_64-unknown-linux-gnu) |
On Tue, Sep 06 2016, Eli Zaretskii wrote:
>> From: Michal Nazarewicz <mina86@mina86.com>
>> Date: Tue, 6 Sep 2016 15:31:29 +0200
>>
>> * src/casefiddle.c (casify_region): use STRING_CHAR_AND_LENGTH as a safe
>> alternative to FETCH_MULTIBYTE_CHAR which is documented in src/buffer.h
>> as unsafe when used for advancing index.
>
> AFAIK, that comment is stale and no longer correct. I don't think
> there's a reason to make this change anymore, since STRING_CHAR no
> longer unifies characters.
I’ll drop the patch in favour of updating the comment in
FETCH_MULTIBYTE_CHAR then.
/me wonders if STRING_CHAR_AND_LENGTH must be faster than
FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES.
--
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»
- bug#24378: [PATCH 6/6] Factor out character category lookup to separate function, (continued)
bug#24378: [PATCH 5/6] Don’t allocate char-table’s extra slots in regexp-out-charset, Michal Nazarewicz, 2016/09/06
bug#24378: [PATCH 3/6] Replace decimalnump with alphanumericp, Michal Nazarewicz, 2016/09/06
bug#24378: [PATCH 2/6] Remove inaccurate comment in regex.c, Michal Nazarewicz, 2016/09/06
bug#24378: [PATCH 4/6] Remove dead loop iterations in regex.c, Michal Nazarewicz, 2016/09/06
bug#24378: [PATCH 1/6] Don’t use FETCH_MULTIBYTE_CHAR when advancing index, Eli Zaretskii, 2016/09/06
bug#24378: [PATCH] Remove obsolete comment from FETCH_MULTIBYTE_CHAR documentation, Michal Nazarewicz, 2016/09/06
bug#24378: [PATCH 0/6] Small fixes and improvements, Michal Nazarewicz, 2016/09/09