[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even a
From: |
Eli Zaretskii |
Subject: |
bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep |
Date: |
Thu, 05 May 2016 05:44:39 +0300 |
> Cc: 23453@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Thu, 5 May 2016 01:15:37 +0300
>
> Oops, thanks for catching this.
>
> On 05/05/2016 12:39 AM, Kaushal Modi wrote:
>
> > + (shell-quote-argument dir)
>
> This looks good.
>
> > + (xref--find-ignores-arguments ignores (shell-quote-argument dir))))
>
> I'm not sure about this line, on the other hand. Is it actually
> required? If yes, this quoting should be performed inside
> xref--find-ignores-arguments, I think.
Indeed, it is IMO wrong to use shell-quote-argument anywhere except
immediately before invoking the shell command. If this is what is
needed to fix the bug, the bug is elsewhere.
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep, Kaushal Modi, 2016/05/04
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep, Eli Zaretskii, 2016/05/04
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep, Kaushal Modi, 2016/05/04
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep, Kaushal Modi, 2016/05/04
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep, Kaushal Modi, 2016/05/04
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep, Kaushal Modi, 2016/05/04
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep, Dmitry Gutov, 2016/05/04
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep, Kaushal Modi, 2016/05/04
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep, Dmitry Gutov, 2016/05/04
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep, Kaushal Modi, 2016/05/05
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep,
Eli Zaretskii <=
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep, Eli Zaretskii, 2016/05/04
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep, Kaushal Modi, 2016/05/05
- bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep, Eli Zaretskii, 2016/05/05