[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb

From: Lars Ingebrigtsen
Subject: bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el?
Date: Fri, 29 Apr 2016 16:00:11 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

Drew Adams <address@hidden> writes:

> `menu-bar-select-buffer' is defined in `menu-bar.el'.  It used to be
> used there as well, in function `menu-bar-update-buffers'.
> Now, the latter function uses `menu-bar-select-buffer-function' instead
> (which makes no use of `menu-bar-select-buffer').  The only place
> `menu-bar-select-buffer' is used now is in `msb.el'.
> Why not remove `menu-bar-select-buffer' or move it to `msb.el'?

Well, there may be third party usages of this very important function, I

(defun menu-bar-select-buffer ()
  (switch-to-buffer last-command-event))

And it's unclear whether it's used in msb.el.  The only mention is:

(defun msb--make-keymap-menu (raw-menu)
  (let ((end 'menu-bar-select-buffer)
        (mcount 0))

But it could be funcalled afterwards...  the logic is unclear...

(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

reply via email to

[Prev in Thread] Current Thread [Next in Thread]